Restore r->write_event_handler after reading request body#131
Closed
defanator wants to merge 6 commits intoowasp-modsecurity:masterfrom
Closed
Restore r->write_event_handler after reading request body#131defanator wants to merge 6 commits intoowasp-modsecurity:masterfrom
defanator wants to merge 6 commits intoowasp-modsecurity:masterfrom
Conversation
Collaborator
Author
|
@zimmerle @victorhora this one is ready for review. Latest failures are caused by libmodsecurity compilation errors, it works just fine with a snapshot as of owasp-modsecurity/ModSecurity@662fe63. |
Collaborator
Author
|
I initiated rebuild after |
Collaborator
Author
|
@victorhora I'd consider this one as bugfix, not enhancement, YMMV :) Have you had a chance to review / test / verify? |
Contributor
|
Indeed @defanator hehe. It seems like we need to create more tags here :) Sorry, we didn't had the time to look at this yet. Will have a look and let you know! Thanks! :) |
zimmerle
pushed a commit
that referenced
this pull request
Nov 29, 2018
Contributor
|
Merged! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130.
Tests included.